Skip to content

151 support for ror identifiers#153

Open
amadulhaxxani wants to merge 7 commits into
clarin-v7from
151-support-for-ror-identifiers
Open

151 support for ror identifiers#153
amadulhaxxani wants to merge 7 commits into
clarin-v7from
151-support-for-ror-identifiers

Conversation

@amadulhaxxani

@amadulhaxxani amadulhaxxani commented Jun 16, 2026

Copy link
Copy Markdown

Problem description

The frontend did not support ROR identifiers for publisher fields. While the author field (with ORCID) already used authority values for search links and displayed the ORCID icon, the publisher field only used plain text values for search links and had no visual indicator for ROR.

When the backend added ROR authority support, the publisher search link still used equals operator with the text value, not the authority operator with the ROR ID. The frontend also lacked a ROR icon to indicate that the publisher has a ROR authority.

Analysis

The publisher field uses a different component and data-extraction path than the author field:

  • Author uses type="author"ClarinItemAuthorPreviewComponentloadItemAuthors → iterates over item.allMetadata(fields) (preserves authority).
  • Publisher uses type="search" → inline *ngFor loop in ClarinGenericItemFieldComponentgetLinkToSearch() → calls item.firstMetadataValue() (loses authority).

As a result, getLinkToSearch always built the search URL with ,equals and never checked for authority. The search result cards (using ds-clarin-item-box-view) also used firstMetadataValue() and ignored authority.

Copilot review

  • Requested review from Copilot

fix(item-view): use authority value for publisher search links (ROR)
…t cards

fix(search-results): use authority value for publisher links on result cards
feat(ror): add ROR icon to publisher links on item view and search cards
…rect

fix(ror-itempage-search-results): put the image in the publisher redirect
fix(ror-icon): add icon in the item page
@amadulhaxxani amadulhaxxani linked an issue Jun 16, 2026 that may be closed by this pull request
fix(lint): remove redundant type annotation for hasPublisherAuthority

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds frontend support for ROR-backed publisher metadata by preserving and using authority values when building publisher search links, and by displaying a ROR icon when a publisher authority is present.

Changes:

  • Add a ROR SVG icon asset and render it next to authority-backed publisher values.
  • Update publisher search link construction to use ,authority with the authority ID instead of ,equals with the plain text value.
  • Update generic “search” item-field links to prefer authority when available.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/assets/images/ror-icon.svg Adds a new ROR icon asset for display next to authority-backed publishers.
src/app/shared/clarin-item-box-view/clarin-item-box-view.component.ts Detects publisher authority and builds publisher search links using authority when present.
src/app/shared/clarin-item-box-view/clarin-item-box-view.component.html Displays publisher link with optional ROR icon in search result cards.
src/app/item-page/simple/field-components/clarin-generic-item-field/clarin-generic-item-field.component.ts Builds search links using authority operator when the metadata value has an authority.
src/app/item-page/simple/field-components/clarin-generic-item-field/clarin-generic-item-field.component.html Shows a ROR icon next to authority-backed values in “search” fields.

Comment thread src/app/shared/clarin-item-box-view/clarin-item-box-view.component.html Outdated
Comment thread src/app/shared/clarin-item-box-view/clarin-item-box-view.component.ts Outdated
feat(ror): add ROR icon and authority-based publisher search links
@amadulhaxxani amadulhaxxani requested a review from kosarko June 17, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for ROR identifiers

2 participants