Update Equal Access engine - #3
Merged
Merged
Conversation
af63626 replaced the engine bundle with an upstream IBM build, which dropped the customisations this server relies on and regressed list detection for UDOIT: - reported the containing block instead of each list item - could not detect one-item-per-<p> lists (the shape the Canvas RCE produces when authors press Enter) - narrowed separators to [.)], losing "-" and ":" - capped roman numerals at xv - dropped the circle/filled-circle/square bullet glyphs This restores the customised engine (extended bullets, [.)\-:] separators, full roman numeral matching, and the first-of-sibling-run check that enables per-<p> reporting). Also fixes uppercase roman numerals, which never worked: LIST_ITEM_PATTERN is composed from `.source` strings, which discards the ordered pattern's `i` flag, so the lowercase-written roman branch could not match "II."/"III.". The flag is now passed explicitly to the RegExp constructor. Verified by rebuilding Dockerfile.ace and scanning: numbered, lettered (both cases), roman (both cases, beyond xv), bullet glyphs, and the "." ")" "-" ":" separators are all detected, in both <p>-per-item and <br>-separated form. Proper <ol>/<ul>, prose containing numbers, and single-item paragraphs remain clean.
mbusch3
approved these changes
Sep 18, 2026
mbusch3
left a comment
mbusch3
left a comment
There was a problem hiding this comment.
I'm not 100% sure how this update will affect existing builds, so I've created a dev branch and am merging this there. I'll test by editing my local docker-compose.nginx.yaml file to pull from dev and see if I get the new scanner build.
Co-authored-by: mbusch3 <16626644+mbusch3@users.noreply.github.com>
mbusch3
approved these changes
Sep 18, 2026
mbusch3
left a comment
mbusch3
left a comment
There was a problem hiding this comment.
This is a Copilot issue fix. I'm merging to test.
There was a problem with the build process where the github.ref_name sometimes returned an invalid format (if you look at the build logs, we got :3/main).
This attempts to create a new tag which is always valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.