fix(runway): ISS-011 fail fast without Git configuration - #677
Draft
sbalabanov wants to merge 1 commit into
Draft
Conversation
Summary: Intent: - Prevent an explicit Git merger selection from silently starting with the noop merger. - Keep automatic noop fallback and explicit noop/fake overrides unchanged. Changes: - Validate startup configuration when MERGER=git and require at least one usable Git target. - Cover environment and file-based Git configuration, Git-less files, noop, fake, unset, and invalid selections. - Document the explicit Git startup contract. Reproduction: - Deploy Runway with MERGER=git while omitting both MERGE_CONFIG_PATH and MERGE_CHECKOUT_PATH. - Previously the service started with the noop merger and could publish synthetic successful merge results without changing Git. - Startup now fails with: MERGER="git" requires usable Git configuration: set MERGE_CHECKOUT_PATH or set MERGE_CONFIG_PATH to a config containing at least one git merger. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Reproduction:
Generated by the 🪄 pr-create skill in devexp-agent-marketplace
Test Plan
AI Verification
0 issues detected
Skipped validators: claude · EngWiki
Issues
T3-ISS-011