Skip to content

fix(runway): ISS-010 stop logging queue credentials - #676

Draft
sbalabanov wants to merge 1 commit into
mainfrom
sergeyb/fix-iss-010-redact-queue-dsn
Draft

fix(runway): ISS-010 stop logging queue credentials#676
sbalabanov wants to merge 1 commit into
mainfrom
sergeyb/fix-iss-010-redact-queue-dsn

Conversation

@sbalabanov

@sbalabanov sbalabanov commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Intent

  • Prevent QUEUE_MYSQL_DSN credentials and query parameters from appearing in Runway startup logs.
  • Preserve a useful queue-initialization signal without rendering connection configuration.

Changes

  • Log the queue backend instead of the raw DSN.
  • Add observer-based regression coverage with sentinel username, password, and query values.

Reproduction

Before the fix, starting Runway with QUEUE_MYSQL_DSN=user:super-secret@tcp(mysql:3306)/submitqueue?parseTime=true produced initialized queue {"dsn":"user:super-secret@tcp(mysql:3306)/submitqueue?parseTime=true"}.

After the fix, the same configuration produces initialized queue {"backend":"mysql"} with no DSN components.


Generated by the 🪄 pr-create skill in devexp-agent-marketplace

Summary:
Intent:
- Prevent QUEUE_MYSQL_DSN credentials and query parameters from appearing in Runway startup logs.
- Preserve a useful queue-initialization signal without rendering connection configuration.

Changes:
- Log the queue backend instead of the raw DSN.
- Add observer-based regression coverage with sentinel username, password, and query values.

Reproduction:
- Before: `QUEUE_MYSQL_DSN=user:super-secret@tcp(mysql:3306)/submitqueue?parseTime=true` produced `initialized queue {"dsn":"user:super-secret@tcp(mysql:3306)/submitqueue?parseTime=true"}`.
- After: the same configuration produces `initialized queue {"backend":"mysql"}` with no DSN components.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants