Skip to content

Add onMouseUp handler to changeHandlers - #5426

Closed
MaddipatlaChetan24 wants to merge 1 commit into
uber:mainfrom
MaddipatlaChetan24:patch-13
Closed

MaddipatlaChetan24 wants to merge 1 commit into
uber:mainfrom
MaddipatlaChetan24:patch-13

Conversation

@MaddipatlaChetan24

Copy link
Copy Markdown
Contributor

Fixes #1, Fixes #2

Description

changeHandlers in common.ts had no onMouseUp entry, even though its sibling handlers (onMouseDown, onMouseEnter, onMouseLeave) were all present. This was the missing companion piece for the checkbox-v2.ts change that picks "onMouseUp" from changeHandlers — without this, that pick resolves to undefined. Added an onMouseUp entry, mirroring onMouseDown's shape exactly (value: undefined, type: PropTypes.Function, hidden: true).

Scope

Patch: Bug Fix

@MaddipatlaChetan24

Copy link
Copy Markdown
Contributor Author

Companion fix for #5424 — that PR picks "onMouseUp" from
changeHandlers, but common.ts had no onMouseUp entry to pick,
so it resolved to undefined. This PR adds it, mirroring
onMouseDown's shape exactly.

Both PRs are needed together for the fix to actually work. cc
@dyesin — #5424 was flagged as a breaking change; I don't see how
adding a new key here breaks anything on its own, but flagging in
case the concern was actually about this file.

@dyesin

dyesin commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR. Before we review it, please note that "check this" isn't a submission we can accept. It hands the verification work to maintainers, and our review time is limited.

We welcome AI-assisted contributions, but you are the author and must stand behind every line. Before requesting review, please:

Run it. Set up the dev environment, run the full test suite, and confirm the change works as intended.
Understand it. Be ready to explain why each change was made and what could break. "The model suggested it" isn't an answer.
Justify it. Describe the actual problem this solves and how you confirmed it's fixed. For performance changes, include evidence.
Test it. Add or update tests following the patterns already used in the repo.
Keep it focused. One concern per PR, with no unrelated edits.

Once you can confirm all of the above in the PR description, we're happy to take a look. Until then, we'll mark this as a draft.

@dyesin dyesin closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants