Add onMouseUp handler to changeHandlers - #5426
MaddipatlaChetan24 wants to merge 1 commit into
Conversation
|
Companion fix for #5424 — that PR picks Both PRs are needed together for the fix to actually work. cc |
|
Thanks for the PR. Before we review it, please note that "check this" isn't a submission we can accept. It hands the verification work to maintainers, and our review time is limited. We welcome AI-assisted contributions, but you are the author and must stand behind every line. Before requesting review, please: Run it. Set up the dev environment, run the full test suite, and confirm the change works as intended. Once you can confirm all of the above in the PR description, we're happy to take a look. Until then, we'll mark this as a draft. |
Fixes #1, Fixes #2
Description
changeHandlers in common.ts had no onMouseUp entry, even though its sibling handlers (onMouseDown, onMouseEnter, onMouseLeave) were all present. This was the missing companion piece for the checkbox-v2.ts change that picks "onMouseUp" from changeHandlers — without this, that pick resolves to undefined. Added an onMouseUp entry, mirroring onMouseDown's shape exactly (value: undefined, type: PropTypes.Function, hidden: true).
Scope
Patch: Bug Fix