Add PostgreSQL 18 support and make it the default image version - #2
Conversation
Co-authored-by: naorpeled <6171622+naorpeled@users.noreply.github.com>
Co-authored-by: naorpeled <6171622+naorpeled@users.noreply.github.com>
Co-authored-by: naorpeled <6171622+naorpeled@users.noreply.github.com>
Co-authored-by: naorpeled <6171622+naorpeled@users.noreply.github.com>
PR Summary by QodoAdd PostgreSQL 18 support and make it the default image
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo
1.
|
| PG_MAJOR_VERSION: ${PG_MAJOR:-16} # Environment variable PG_MAJOR, defaults to 16 | ||
| POSTGIS_MAJOR_VERSION: ${POSTGIS_MAJOR_VERSION:-3} # Environment variable POSTGIS_MAJOR_VERSION, defaults to 3 | ||
| PGVECTOR_TAG: ${PGVECTOR_VERSION:-v0.8.0} # Environment variable PGVECTOR_VERSION, defaults to v0.8.0 | ||
| PG_VERSION: ${PG_VERSION:-18.3} # Environment variable PG_VERSION, defaults to 18.3 |
There was a problem hiding this comment.
1. Recreated databases lose their data 🐞 Bug ☼ Reliability
docker-compose.yml defaults the build to PostgreSQL 18.3 but still mounts postgres_data at /var/lib/postgresql/data, while the official PostgreSQL 18 image stores its cluster under /var/lib/postgresql/18/docker. With the default Compose configuration, database writes miss the declared persistent volume, so recreating the container does not restore its data; the README’s docker run example uses the same outdated mount path.
Agent Prompt
## Issue description
The new PostgreSQL 18 default writes its cluster outside the persistent volume mounted by Compose. The README's `docker run` example has the same mount path.
## Fix Focus Areas
- docker-compose.yml[6-18]
- README.md[49-57]
## Recommended Fix
Mount the volume at `/var/lib/postgresql` for PostgreSQL 18 and update the README example to match. Document how existing PostgreSQL 17 volumes should be migrated rather than treating a mount-path change as an automatic major-version upgrade.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
@copilot fix the issue, but make sure ro not break previous versions' runs |
Co-authored-by: naorpeled <6171622+naorpeled@users.noreply.github.com>
Fixed in |
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit e6ba5ba |
Co-authored-by: Lucian Mocanu <alumni@users.noreply.github.com>
|
/agentic_review |
|
@copilot address Qodo's feedback |
|
Code review by qodo was updated up to the latest commit 5f8c2d7 |
Co-authored-by: naorpeled <6171622+naorpeled@users.noreply.github.com>
Addressed in |
This updates the image matrix to include PostgreSQL 18 and promotes it to the default published/runtime target. It also aligns local compose usage and documentation with the actual build arguments used by the image.
Version matrix
18.3toversions.jsonlatestDefault image target
Compose alignment
PG_VERSIONPOSTGIS_VERSIONPGVECTOR_VERSION18.3, PostGIS3.6.2, pgvector0.8.2postgres:18) so local test composition does not depend on a patch-tagged client image existingDocumentation