Skip to content

Remove name funciton from EffectSuite.#317

Open
zainab-ali wants to merge 1 commit intotypelevel:mainfrom
zainab-ali:remove-name-from-effect-suite
Open

Remove name funciton from EffectSuite.#317
zainab-ali wants to merge 1 commit intotypelevel:mainfrom
zainab-ali:remove-name-from-effect-suite

Conversation

@zainab-ali
Copy link
Copy Markdown
Contributor

All weaver suites have a publicly accessible name field corresponding to their class name.

This is confusing for users, who may reference it in their tests by mistake:

import weaver.*

object FooSuite extends SimpleIOSuite {
  pureTest("name should be foo") {
    val nam = "foo" // a typo
    expect("foo", name)
  }
}

This field should either be removed, or renamed to the more descriptive suiteName.

@zainab-ali zainab-ali marked this pull request as ready for review May 1, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant