Conversation
The pooled resource came out of the map via Resource.eval, which leaves a cancellation point before makeFull registers the finalizer. A cancel landing there dropped the resource without destroying it or returning it to the pool, so the permit and the idle count stayed correct while the connection leaked. Moving the map update into the acquire makes taking the resource and registering its finalizer atomic. Fixes typelevel#708
Author
|
Root cause is upstream, typelevel/cats-effect#4627: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taketook the pooled resource out of the map withResource.eval, which leaves a cancellation point before the bracket registers its finalizer. A cancel there dropped the resource silently. Moving the update into the acquire makes it atomic. Test is JVM only, the race needs real parallelism.Fixes #708