Repository navigation
Conversation
Changes the behavior of `applicationProtocol` on SN to return the empty string when no protocol is negotiated, instead of throwing an exception. `s2n_get_application_protocol` intentionally returns `NULL` to indicate no protocol was negotiated (see: https://aws.github.io/s2n-tls/doxygen/s2n_8h.html#ae53faa26669e258afff875d45140f14e). But FS2 wrapped the call in `guard` which throws on a null pointer. Fixes typelevel#3778
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the behavior of
applicationProtocolon SN to return the empty string when no protocol is negotiated, instead of throwing an exception.s2n_get_application_protocolintentionally returnsNULLto indicate no protocol was negotiated (see: https://aws.github.io/s2n-tls/doxygen/s2n_8h.html#ae53faa26669e258afff875d45140f14e). But FS2 wrapped the call inguardwhich throws on a null pointer.Fixes #3778