Skip to content

Import cats.syntax.all instead of cats.implicits in the kernel #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martijnhoekstra wants to merge 1 commit into
base: series/3.x
Choose a base branch
from
Open

Import cats.syntax.all instead of cats.implicits in the kernel #4711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kernel/shared/src/main/scala/cats/effect/kernel/Async.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package cats.effect.kernel
import cats.{~>, Monoid, Semigroup}
import cats.arrow.FunctionK
import cats.data.{EitherT, Ior, IorT, Kleisli, OptionT, WriterT}
import cats.implicits._
import cats.syntax.all._

import org.typelevel.scalaccompat.annotation.unused

Expand Down
4 changes: 2 additions & 2 deletions kernel/shared/src/main/scala/cats/effect/kernel/instances/GenSpawnInstances.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package cats.effect.kernel.instances
import cats.{~>, Align, Applicative, CommutativeApplicative, Functor, Id, Monad, Parallel}
import cats.data.Ior
import cats.effect.kernel.{GenSpawn, ParallelF}
import cats.implicits._
import cats.syntax.all._

trait GenSpawnInstances {

Expand Down Expand Up @@ -79,7 +79,7 @@ trait GenSpawnInstances {
f: Ior[A, B] => C): ParallelF[F, C] =
ParallelF(
(ParallelF.value(fa).attempt, ParallelF.value(fb).attempt)
.parMapN((ea, eb) => catsStdInstancesForEither.alignWith(ea, eb)(f))
.parMapN((ea, eb) => Align[Either[E, *]].alignWith(ea, eb)(f))
.flatMap(F.fromEither)
)

Expand Down
Loading