Fix equality and hashcode contracts#847
Open
flyingsilverfin wants to merge 1 commit intotypedb:masterfrom
Open
Fix equality and hashcode contracts#847flyingsilverfin wants to merge 1 commit intotypedb:masterfrom
flyingsilverfin wants to merge 1 commit intotypedb:masterfrom
Conversation
…lity Value.equals() previously delegated to Rust's concept_equals via ConceptImpl, while hashCode() used the Java-typed value from get(). This violated the equals/hashCode contract. Override equals() in ValueImpl to use getValueType() + get().equals(), matching hashCode(). Fix Python Datetime.__hash__() to exclude timezone name from the hash tuple, aligning with __eq__() which already compares by UTC instant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage and product changes
Streamline hash and equality contract differences:
Implementation
Java:
Python: