Repository navigation
Close temporary async sessions when requests fail - #966
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pool_connections=False, request failures, body-decoding errors and cancellation can leave the per-request aiohttp session open. Close temporary sessions in a finally block while preserving pooled-session ownership.
Adds five regression tests. The three failure-path tests fail before this fix and pass afterward.
Validation: async HTTP tests 12 passed; flake8 and formatting checks passed. Full make test: 644 passed, 2 existing proxy-test failures caused by this environment's REQUESTS_CA_BUNDLE value. Both failures were reproduced with unchanged upstream implementation.
Prepared with Codex assistance.