Skip to content

fix(getting-started): one Refresh for all setup wizard lists, Conversation Configuration naming - #130

Open
ryanrishi wants to merge 3 commits into
mainfrom
setup-wizard-refresh-and-naming
Open

ryanrishi wants to merge 3 commits into
mainfrom
setup-wizard-refresh-and-naming

Conversation

@ryanrishi

@ryanrishi ryanrishi commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Three fixes to the setup wizard page (getting_started/twilio_setup/templates/index.html):

  • The left Refresh now loads the Memory Store dropdown and both right-hand panels (Existing Memory Stores, Existing Conversation Configurations) — they all run off the same credentials, but each had its own Refresh and only the dropdown filled
  • The Conversation Configuration section shows "Select a Memory Store above to continue" while it's locked (it stays greyed out until a store is picked, with no explanation)
  • "Orchestrator" in the section header, progress step and right-hand panel is now Conversation Configuration(s) — the resource the wizard actually creates and lists

Also, from review on the TypeScript side:

  • Display names are limited to letters, numbers, _ and - in both the page and server.py — the ConversationConfiguration model rejects . and ~, and TAC validates the configuration on startup, so a wizard-created name using them stopped the examples from starting
  • The error panel's ✕ button was an implicit type="submit" inside setupForm, so dismissing it could start another setup run
  • One setup run at a time — Memory Store controls lock during a run and the selected store can't change mid-run, so profile and configuration creation can't target a different store
  • Creating a Memory Store auto-selects the new store, not the previously saved selection the refresh restores
  • server.py binds to 127.0.0.1 by default, since the page takes credentials over plain HTTP; TAC_SETUP_HOST=0.0.0.0 opts in to remote access
  • No remote scripts on the credential-entry page: Tailwind CSS is generated and inlined instead of loaded from the Tailwind CDN, with the regeneration command in the wizard README

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Release / version bump

Checklist

  • Tests added/updated
  • Documentation updated
  • Tested E2E

SDK Parity

The TypeScript wizard serves a byte-identical copy of this page; the same changes are on that PR.

🤖 Generated with Claude Code

…use Conversation Configuration naming

- The left Refresh button now loads the Memory Store dropdown and both
  right-hand panels, since they run off the same credentials. Previously
  each list had its own Refresh and only the dropdown filled.
- The Conversation Configuration section shows "Select a Memory Store above
  to continue" while it's locked, since it stays greyed out until a Memory
  Store is picked.
- The section header, progress step and right-hand panel said
  "Orchestrator"; they now say Conversation Configuration(s), the resource
  the wizard actually creates and lists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused page changes correctly implement the described behavior without unresolved issues.

Review effort: Balanced
Findings: None

What changed in this PR

Updates the setup wizard to unify resource refresh behavior and clarify Conversation Configuration terminology.

Changes:

  • Refreshes all resource lists from the primary Refresh button.
  • Adds guidance when no Memory Store is selected.
  • Renames user-facing Orchestrator labels.
File Description
getting_started/​twilio_setup/​templates/​index.html Updates refresh behavior, guidance text, and resource labels.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

ryanrishi and others added 2 commits October 8, 2026 11:42
… time

- Restrict Conversation Configuration display names to letters, numbers,
  `_` and `-`. The SDK's ConversationConfiguration model rejects `.` and
  `~`, and TAC validates the configuration on startup, so a name using
  them stopped the examples from starting.
- The error panel's close button no longer submits the setup form.
- Only one setup run at a time: Memory Store controls are locked and the
  selected store can't change while a run is in flight, so profile and
  configuration creation can't target a different store mid-run.
- Creating a new Memory Store auto-selects it rather than the previously
  saved selection the refresh restores.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…scripts

- Bind to 127.0.0.1 by default; TAC_SETUP_HOST=0.0.0.0 opts in to remote access.
- Inline generated Tailwind CSS in place of the Tailwind CDN script, so no
  third-party code runs on the credential-entry page. The README documents
  how to regenerate it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wenzhu1587
wenzhu1587 previously approved these changes Oct 13, 2026
@wenzhu1587
wenzhu1587 force-pushed the setup-wizard-refresh-and-naming branch from eba3b57 to f1b2955 Compare October 13, 2026 23:14

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants