Release GIL while resampling#14
Open
tuxu wants to merge 3 commits into
Open
Conversation
acquire GIL for execution of callback
attempt to fix exception handling on windows, not tested
|
builds and works in parallel on windows 11 cpython 3.11 👍 I only use src_simple so that's about all I can tell you. 🤷 If you push a github release when this lands, I'll be notified 🍰 |
richardsheridan
added a commit
to richardsheridan/magic-afm
that referenced
this pull request
Feb 2, 2024
pending tuxu/python-samplerate#14 This reverts commit 92bfc32. Also changes requirements pin
Bentroen
added a commit
to OpenNBS/nbswave
that referenced
this pull request
Dec 10, 2024
This commit implements the change proposed in tuxu/python-samplerate#14 via issue tuxu/python-samplerate#13
Draft
8 tasks
|
I was able to get up to 20x faster exports in my use case, where it's necessary to perform resampling 50k+ times (see OpenNBS/nbswave#8). Would love to see this merged soon :) |
|
@tuxu anything we as a community do to help you out with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13.