Replace sparse candidate maps with a bounded typed table#130
Closed
AnasSarkiz wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
Member
Author
|
/benchmark --dataset srj18 |
Member
Author
|
Superseded by #132, a fresh latest-main branch with the profiled candidate-cost hot-path fix and no sparse-storage experiment history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Sparse mode advanced a generation counter on every route search, but both Maps retained every hop ever visited. Large SRJ18 boards therefore accumulated stale entries across rerips and paid two Map lookups for every candidate-cost access.
Validation
bun test --timeout 9999999: 98 pass, 0 failbun run typecheckbun run buildCompatibility
This branch starts directly from current upstream main. It contains no prior experimental routing commits and introduces no new public solver option or package export.