[codex] Revert memory optimizations that change routing output#116
Draft
0hmX wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This reverts the
7891dd9memory-optimization changes that altered routing output in downstream snapshot tests.Reverted areas:
core.tsWhy
The changes were introduced as memory optimizations, but they were not output-neutral.
A downstream consumer (
tscircuit-autorouter) started failing SVG snapshot tests after updating to7891dd9. The clearest repro wastests/e2e3.test.ts, which passed on1487056, failed on7891dd9, and passed again after reverting this change set.The highest-signal behavior change was the new empty-section fast path in
TinyHyperGraphSectionPipelineSolver, which skipsoptimizeSectionentirely when the section mask is empty. In pipeline4 consumers that path is exercised and changes final routing geometry.Impact
This restores pre-
7891dd9routing behavior for consumers that depend on stable tiny-hypergraph output.Validation
Validated from the linked
tscircuit-autoroutercheckout using the local path dependency:bun test tests/e2e3.test.tsbun test tests/e2e3.test.ts tests/e2e3-multisection.test.tsrg -l "toMatchGraphicsSvg|toMatchSvgSnapshot" tests | sort > temp/svg-test-files.txtxargs bun test < temp/svg-test-files.txtObserved result in the sweep: