Skip to content

[Codex] Fix net-label-only trace routing#556

Open
caaeco wants to merge 1 commit into
tscircuit:mainfrom
caaeco:bounty-79-net-label-connectivity
Open

[Codex] Fix net-label-only trace routing#556
caaeco wants to merge 1 commit into
tscircuit:mainfrom
caaeco:bounty-79-net-label-connectivity

Conversation

@caaeco

@caaeco caaeco commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • isolate physical direct-connectivity data from logical net-label connectivity
  • restrict primary MSP and long-distance routing to directly wired nets
  • add focused regressions proving net-label-only connections do not produce physical traces
  • update affected visual snapshots and repro expectations to reflect removal of the spurious traces

Root cause

netConnMap was initialized with the mutable backing map from directConnMap. Adding logical netConnections therefore also mutated the direct-only connectivity map, and both routing stages iterated the merged connectivity. Net-label-only pins were consequently treated as physical wires.

Validation

  • bun test: 73 passed, 4 skipped, 0 failed
  • pnpm run build: passed (ESM + declarations)
  • git diff --check: passed

/claim #79

@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-trace-solver Ready Ready Preview, Comment Jun 21, 2026 2:47pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant