fix(tagxl): classify supported configuration actions - #211
Conversation
Land the #210 squash on main. The original PR was merged into the already-merged parent branch, so action analysis never reached main.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (6)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughChangesConfiguration validation and action handling
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant Caller
participant AnalyzeConfiguration
participant parseConfigurationSent
participant dialectSpec
Caller->>AnalyzeConfiguration: provide dialect and sent hex
AnalyzeConfiguration->>parseConfigurationSent: parse configuration
parseConfigurationSent->>dialectSpec: read supported actions
dialectSpec-->>parseConfigurationSent: return action definitions
parseConfigurationSent-->>AnalyzeConfiguration: return requirements and action presence
AnalyzeConfiguration-->>Caller: return analysis or validation error
Merge Risk: ⚪ Minimal · up to The configuration validation and action-handling changes have no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Summary
This is the same content as #210 / `v1.6.0-rc2`: Tag XL `0x80`–`0x84`, Smart Label v2 `0x81`–`0x84`, Tag S/L sent validators.
API follow-up: https://github.com/truvami/api/pull/1022 still pins `v1.6.0-rc2` until this is merged.
Test plan
Summary by CodeRabbit
New Features
Bug Fixes