feat(tagxl): distinguish incomplete configuration reports - #204
niko-kriznik-globtim wants to merge 1 commit into
Conversation
Campaign verification must not treat partial port-151 uplinks as contradictions. CompareConfiguration now returns match, complete mismatch, or incomplete when a requested setter is absent.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughChangesConfiguration comparison
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change classifies partial configuration reports as incomplete while preserving complete match and mismatch behavior. Current coverage includes incomplete, matching, mismatching, and missing-field cases, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
API consumer: https://github.com/truvami/api/pull/988 (pseudo-version of this commit until tagged from main). |
Summary
CompareConfigurationso Tag XL port-151 reports are classified as match, complete mismatch, or incomplete.MatchConfigurationas a compatibility wrapper that is true only on a complete match.Depends on nothing. Used by truvami/api#987.
Test plan
go test ./pkg/decoder/tagxl/v1/ -run 'TestMatchConfiguration|TestCompareConfiguration|TestConfigurationComparisonString|TestPort151PayloadConfig'Summary by CodeRabbit
New Features
Bug Fixes