Repository navigation
Answer NotFound to GET DATA for an unknown data object tag - #54
Open
FlorianFranzen wants to merge 1 commit into
Open
FlorianFranzen wants to merge 1 commit into
FlorianFranzen wants to merge 1 commit into
Conversation
FlorianFranzen
added a commit
to FlorianFranzen/piv-authenticator
that referenced
this pull request
Oct 16, 2026
- ccaff6c Answer NotFound to GET DATA for an unknown data object tag
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET DATA with a well-formed tag the card does not know answered IncorrectDataParameter, the same status as a malformed command. A YubiKey answers NotFound for a data object it does not have, and ykman relies on that: every
ykman pivsubcommand first reads its own object5FFF00(pivman data) and treats FILE_NOT_FOUND as "empty", so against this app all of them failed on that first APDU. The parser now maps an unknown container tag to NotFound; malformed tags and PUT DATA to an unknown tag keep IncorrectDataParameter.Tested in
command_response.ron: three unknown tags answer NotFound.