Display: sync resolution popups after a revert, fix stale last-good#541
Open
armm77 wants to merge 1 commit into
Open
Display: sync resolution popups after a revert, fix stale last-good#541armm77 wants to merge 1 commit into
armm77 wants to merge 1 commit into
Conversation
Two related defects in the resolution-revert flow of the Display module: 1. When a resolution was rejected (Revert pressed or the countdown expired), the display reverted correctly but the resolution popup kept showing the rejected resolution. The popup selection was only ever set in monitorsListClicked:, and the revert path returned early without touching the UI. Reselect the active resolution and rebuild the refresh-rate popup in the "reverted to last good" branch. 2. Pressing Keep did not update lastGoodResolution, so it still held the resolution that was active when the monitor was selected. A later change followed by a revert would then jump back two steps instead of to the kept resolution. Record the active resolution as the new last-good when the user keeps it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related defects in the resolution-revert flow of the Display module:
When a resolution was rejected (Revert pressed or the countdown expired), the display reverted correctly but the resolution popup kept showing the rejected resolution. The popup selection was only ever set in monitorsListClicked:, and the revert path returned early without touching the UI. Reselect the active resolution and rebuild the refresh-rate popup in the "reverted to last good" branch.
Pressing Keep did not update lastGoodResolution, so it still held the resolution that was active when the monitor was selected. A later change followed by a revert would then jump back two steps instead of to the kept resolution. Record the active resolution as the new last-good when the user keeps it.