GitAuto setup#3
Conversation
Co-Authored-By: Tronpis <genaroperezpousa0@gmail.com>
There was a problem hiding this comment.
AI Code Review by LlamaPReview
🎯 TL;DR & Recommendation
Recommendation: Approve with suggestions
This PR adds a test-specific TypeScript config that relaxes unused variable checks, but lacks documentation for the rationale, which may hinder future maintainability.
💡 Suggestions (P2)
- tsconfig.test.json: Disabling
noUnusedLocalsandnoUnusedParametersfor all test files can mask genuinely dead code; consider adding a comment explaining the rationale.
💡 Have feedback? We'd love to hear it in our GitHub Discussions.
✨ This review was generated by LlamaPReview Advanced, which is free for all open-source projects. Learn more.
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "noUnusedLocals": false, | ||
| "noUnusedParameters": false | ||
| } | ||
| } |
There was a problem hiding this comment.
P2 | Confidence: Medium
The new tsconfig.test.json disables noUnusedLocals and noUnusedParameters for all test files. While this prevents build failures from test-specific patterns (e.g., unused done callbacks), it also suppresses detection of genuinely dead code or unintentional unused variables and parameters across the entire test suite. Over time, this can lead to accumulation of unused code, reducing readability and potentially masking logic errors. The change lacks any documentation explaining why these checks are disabled, which hinders future maintainers. Since the decision is intentional and not a bug, the issue is a low-priority maintainability concern.
Code Suggestion:
{
"extends": "./tsconfig.json",
"compilerOptions": {
// Relax unused-variable checks to avoid false positives in test callbacks and mocks.
"noUnusedLocals": false,
"noUnusedParameters": false
}
}There was a problem hiding this comment.
Added a comment to tsconfig.test.json explaining the rationale for disabling noUnusedLocals and noUnusedParameters.
There was a problem hiding this comment.
I have addressed the reviewer's feedback by adding the requested comment to tsconfig.test.json and replying to the comment. I have verified the change. No other feedback was provided.
Co-Authored-By: <184758061+llamapreview[bot]@users.noreply.github.com>
Summary
This PR configures the repository for GitAuto.
Changes
Summary by cubic
Set up GitAuto by adding
tsconfig.test.jsonfor tests, extendingtsconfig.jsonand disabling unused-variable checks to prevent test build failures.Written for commit 0a1f890. Summary will update on new commits.