fix(cli): report build log stream failures clearly and exit instead of hanging - #4887
Open
myftija wants to merge 6 commits into
Open
fix(cli): report build log stream failures clearly and exit instead of hanging#4887myftija wants to merge 6 commits into
myftija wants to merge 6 commits into
Conversation
…d of hanging When the log stream for a build server deploy fails mid-build, the CLI printed the raw stream error and then kept running until some handle timed out about an hour later. It now stops the spinner, says the stream was lost and that the deployment itself is still running, and exits with code 1 right away, since it cannot know the final outcome.
…arrives Returning from the event loop cancels the underlying read session, so a late transport error cannot discard a finalized result that was already received, and the stream cannot keep reconnecting after the build is done.
Failing to open the stream and losing it mid-build leave the CLI in the same position, unable to confirm the deployment outcome, so both now use the same message and exit code.
🦋 Changeset detectedLatest commit: 2a0691b The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (41)
WalkthroughThe CLI now converts build log stream and read-session failures into a non-zero Merge Risk: 🔵 Low · up to The CLI now surfaces build log stream failures as deployment errors while the server-side deployment continues. Required telemetry instrumentation remains absent from changed paths, reducing operational visibility into this failure behavior. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkResolution Update the description to follow the repository template. Add a Closes #<issue> reference, complete the checklist, document the test steps and results, add a short changelog entry, and include screenshots or state that they are not applicable.
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the build log stream failed during a build server deploy, the CLI printed the raw stream error (e.g.
X Error: Invalid access token) and then hung the process. Only the log stream was lost, the deployment itself kept running.The CLI now stops the spinner, says the log stream failed and that the deployment continues on the build server, links the dashboard, and exits 1 right away. The non-zero exit is deliberate: the CLI can no longer confirm the outcome. Failing to open the stream now behaves the same way instead of exiting 0.
Fix
OutroCommandError, which exits the process instead of waiting for open handles.finalizedevent, which cancels the read session directly. A late transport error can no longer discard a result already received or keep the stream reconnecting after the build is done.