Refactor witness gateway - #1099
Open
AlCutter wants to merge 1 commit into
Open
Conversation
AlCutter
force-pushed
the
witness_like_mirror
branch
3 times, most recently
from
August 7, 2026 16:20
b1b5767 to
8c3eb94
Compare
AlCutter
force-pushed
the
witness_like_mirror
branch
2 times, most recently
from
August 7, 2026 16:40
610b7bf to
9533fa0
Compare
AlCutter
force-pushed
the
witness_like_mirror
branch
from
August 7, 2026 16:45
9533fa0 to
09e140d
Compare
AlCutter
marked this pull request as ready for review
August 7, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the witness gateway behave more like the mirror gateway: the gateway is concerned only with fetching cosigs from witnesses, and policy decisions are now made at the layer above.
This makes both types of "cosigner gateway" look similar, and so we can now reuse common code to process signatures and apply policy.
The custom witness client implementation in the repo has been removed, and we now use the client from the
transparency-dev/witnessrepo instead.Towards #945