Repository navigation
Enforce canonical Base64 decoding across log, note, and policy - #294
Merged
Merged
Conversation
C2SP specs (tlog-checkpoint, signed-note, tlog-cosignature, and tlog-policy) require RFC 4648 Section 3.5 canonical Base64 encoding and mandate that decoders reject non-canonical encodings (non-zero padding bits). Previously, proof.TLogProof.Unmarshal used base64.StdEncoding.Strict(), while log.Checkpoint.Unmarshal, note key/signature/checkpoint decoders, and policy.vkeyPublicKey used base64.StdEncoding.DecodeString, which silently ignored non-zero padding bits in checkpoint root hashes, ML-DSA-44/ECDSA/RFC6962 vkeys, and cosignature timestamps. Switch all remaining production base64.StdEncoding.DecodeString calls to base64.StdEncoding.Strict().DecodeString and add tests across log, note, and policy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 82.57% 90.16% +7.58%
==========================================
Files 5 10 +5
Lines 241 1047 +806
==========================================
+ Hits 199 944 +745
- Misses 30 103 +73
+ Partials 12 0 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AlCutter
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C2SP specs (tlog-checkpoint, signed-note, tlog-cosignature, and tlog-policy) require RFC 4648 Section 3.5 canonical Base64 encoding and mandate that decoders reject non-canonical encodings (non-zero padding bits).
Previously, proof.TLogProof.Unmarshal used base64.StdEncoding.Strict(), while log.Checkpoint.Unmarshal, note key/signature/checkpoint decoders, and policy.vkeyPublicKey used base64.StdEncoding.DecodeString, which silently ignored non-zero padding bits in checkpoint root hashes, ML-DSA-44/ECDSA/RFC6962 vkeys, and cosignature timestamps.
Switch all remaining production base64.StdEncoding.DecodeString calls to base64.StdEncoding.Strict().DecodeString and add tests across log, note, and policy.