Skip to content

Default SDK signatures to sha384#63

Merged
tim-kos merged 2 commits intomainfrom
feat/sha384-signatures
Apr 27, 2026
Merged

Default SDK signatures to sha384#63
tim-kos merged 2 commits intomainfrom
feat/sha384-signatures

Conversation

@tim-kos
Copy link
Copy Markdown
Member

@tim-kos tim-kos commented Apr 27, 2026

Summary

  • default Assembly request signing to sha384
  • include algorithm prefix in generated signatures (sha384:<digest>)
  • add configurable signatureAlgorithm on both Transloadit and TransloaditRequest for legacy sha1 compatibility
  • update tests to cover:
    • default sha384 behavior
    • explicit legacy override (sha1)
    • Node CLI parity using sha384
  • document the new signatureAlgorithm option in README

Why

api2 issue #5337 tracks SDK support for SHA-384 as auth key defaults move to sha384.

Notes

  • Smart CDN signing remains unchanged (sha256) because it is a separate signature mechanism.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Coverage report for commit: 0173ecb
File: ./build/logs/clover.xml

Summary - Lines: 90.55% | Methods: 65.22%
FilesLinesMethodsBranches
lib/transloadit
   CurlRequest.php91.67%66.67%100.00%
   CurlResponse.php100.00%100.00%100.00%
   Transloadit.php86.67%55.56%100.00%
   TransloaditRequest.php92.98%57.14%100.00%
   TransloaditResponse.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1494ff97e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/transloadit/TransloaditRequest.php Outdated
@tim-kos
Copy link
Copy Markdown
Member Author

tim-kos commented Apr 27, 2026

@codex review

@tim-kos tim-kos merged commit 150320d into main Apr 27, 2026
6 checks passed
@tim-kos tim-kos deleted the feat/sha384-signatures branch April 27, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant