Repository navigation
Fix Codex API-key authentication in isolated calls - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex calls currently discard
CODEX_API_KEYwhen building the isolated child environment. Codex 0.162.1 uses that variable as its non-interactive API-key override, so forwarding onlyOPENAI_API_KEYdoes not preserve that authentication path.Preserve
CODEX_API_KEYin the environment allowlist. When its value is nonblank, skip stored-credential lookup and staging, matching Codex's override precedence. This also lets an explicit API key work when the configured keyring is locked. Empty and whitespace-only values retain stored-login behavior. The child still uses its private temporary configuration home.Neither reported authentication case was fixed in v0.2.0. The file/keyring ChatGPT-login fix is already on main through #26; this PR addresses the remaining API-key gap.
Validation:
gmake verifyon Python 3.13, including whole-recipe compiler dry runs with stub agents and synthesized inputs.codex_auth.py.Tests use stub providers/keyring backends; no live provider acceptance or local mutation testing was run.