Reduce transient allocations when stringifying hash keys - #284
Open
OskarEichler wants to merge 3 commits into
Open
Reduce transient allocations when stringifying hash keys#284OskarEichler wants to merge 3 commits into
OskarEichler wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the existing key snapshot and Hash#[] lookups while filling the result directly instead of allocating a pair array per entry.
Reproduction
Verification
nullbreaks parsing #264/Update MultiJSON usage to address deprecations #273 source backports: 544 tests / 700 assertions pass on Ruby 3.2.11, plus 4,410 focused checks and 36 boundary checks. Package retains 104 paths and unchanged compared metadata. All 36 runtime files compile on both Rubies; no newly introduced default Lint offenses.Isolated YJIT measurement: three alternating process pairs, each with five batches of 1,000 conversions of a 100-entry hash. Median time 0.009058→0.007898s; allocations 203,000→102,000. An earlier each_with_object variant was slower and rejected. No production throughput claim.
Breaking changes / limitations
No intended breaking change. Key snapshots, custom Hash#[] behavior, collisions, ordering and value references remain. No recursive conversion or newer Hash#transform_keys API is introduced.
No new/modified checked-in tests. Ruby 2.4–3.1, JRuby, Windows and Linux were not executed locally. Ruby >=2.4 and runtime dependency ranges remain unchanged. External test tooling supplies a legacy MiniTest alias and ruby-prof 1.7.x; no assertions were changed. No production verification is claimed.