Preserve original collection fragments for callbacks - #282
Open
OskarEichler wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capture the collection before processing so setters/filters see neither the previous property nor the last hash item. Restore the parent hash fragment in ensure without a context copy per item. Addresses #231.
Reproduction
Verification
nullbreaks parsing #264/Update MultiJSON usage to address deprecations #273 source backports: 544 tests / 700 assertions pass on Ruby 3.2.11, plus 4,410 focused checks and 36 boundary checks. Package retains 104 paths and unchanged compared metadata. All 36 runtime files compile on both Rubies; no newly introduced default Lint offenses.The initial per-item dup prototype was rejected after it regressed hash rendering. The final restore-in-ensure approach preserves allocations for the 100-entry hash-collection workload (202,000 per 1,000 calls); combined-patch median time 0.021622→0.020985s. A separate hash-render workload is 0.010262→0.010458s with one extra options Hash per render from the separate caller-options fix. These are local YJIT measurements, not a production performance guarantee.
Breaking changes / limitations
Post-collection callbacks receive the original collection fragment. Item fragments still work; other existing shared hash callback state remains shared. Fragment restoration also occurs when an item raises.
No new/modified checked-in tests. Ruby 2.4–3.1, JRuby, Windows and Linux were not executed locally. Ruby >=2.4 and runtime dependency ranges remain unchanged. External test tooling supplies a legacy MiniTest alias and ruby-prof 1.7.x; no assertions were changed. No production verification is claimed.