Parse XML attribute hashes without the removed deserializer - #280
Open
OskarEichler wants to merge 3 commits into
Open
Parse XML attribute hashes without the removed deserializer#280OskarEichler wants to merge 3 commits into
OskarEichler wants to merge 3 commits into
Conversation
seuros
force-pushed
the
codex/xml-attribute-hash-parsing
branch
from
August 29, 2026 09:41
2ea87a1 to
8cb8ef2
Compare
seuros
approved these changes
Aug 29, 2026
seuros
requested changes
Aug 29, 2026
seuros
left a comment
Member
There was a problem hiding this comment.
why was HashDeserializer removed ?
Also a fix will need to have regression test attached.
Thanks for addressing this bug btw.
PS: i rebased this branch.
Author
|
HashDeserializer no longer exists anywhere in the current XML implementation, so the remaining call could not succeed. The branch now reads the node attributes directly and includes a focused regression test for AttributeHash#read. The full xml_bindings_test.rb file passes: 5 tests, 5 assertions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributeHash inherits element lookup despite writing parent attributes. Read attribute nodes and replace the stale reference to nonexistent HashDeserializer.
Reproduction
Verification
nullbreaks parsing #264/Update MultiJSON usage to address deprecations #273 source backports: 544 tests / 700 assertions pass on Ruby 3.2.11, plus 4,410 focused checks and 36 boundary checks. Package retains 104 paths and unchanged compared metadata. All 36 runtime files compile on both Rubies; no newly introduced default Lint offenses.Breaking changes / limitations
Attribute-hash properties now read their emitted data; no parent attributes yields an empty hash. Namespace-qualified attribute semantics are not expanded.
No new/modified checked-in tests. Ruby 2.4–3.1, JRuby, Windows and Linux were not executed locally. Ruby >=2.4 and runtime dependency ranges remain unchanged. External test tooling supplies a legacy MiniTest alias and ruby-prof 1.7.x; no assertions were changed. No production verification is claimed.