Skip to content

PM-5719: Include projected member payments - #118

Merged
jmgasper merged 1 commit into
developfrom
PM-5719-2
Aug 4, 2026
Merged

PM-5719: Include projected member payments#118
jmgasper merged 1 commit into
developfrom
PM-5719-2

Conversation

@jmgasper

@jmgasper jmgasper commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

What was broken

The Member Payment $ by Month and Member Payment $ by Customer dashboards omitted owed and on-hold payments. In QA's July example, both charts showed only an incorrect $51 contest value while Wallet Admin also contained TAAS, task, and engagement payments.

Root cause

The two PM-5719 queries selected only PAID records and grouped them by date_paid. The established Reports dashboard and Wallet Admin semantics use current non-cancelled payments in their creation month so projected amounts remain visible.

What was changed

  • Updated both member-payment queries to select latest non-cancelled payment records and group them by created_at.
  • Preserved the existing gross-amount calculation, payment categorization, billing-account customer resolution, top-five ranking, and Other Customers grouping.
  • Updated the dashboard documentation to describe the corrected projection semantics.

Live finance-source validation for July now resolves to TAAS $3, Task $68, Contest $1,635, and Engagement $3,780, totaling $5,486. The source's distinct member counts also match the established Members Paid dashboard in every category.

Any added/updated tests

  • Updated SQL regression coverage for both payment dashboards to require non-cancelled records grouped by creation month and reject PAID/date_paid filtering.
  • All 5 dashboard suites and 35 tests pass.
  • The production build and changed-file ESLint check pass.
  • The full suite was run: 19 suites and 338 tests pass. The same 3 unrelated SFDC/report-directory suites already documented on the previous attempt still fail on unchanged paths.
  • The repository lint script completes after auto-fixing 3 pre-existing leaderboard formatting issues on develop; those unrelated auto-fixes were intentionally excluded from this scoped PR.

What was broken

The member payment dashboards omitted owed and on-hold July payments, leaving only an incorrect $51 contest total and no TAAS or engagement values.

Root cause

Both dashboard queries required PAID status and grouped values by payout date, unlike the established dashboard and Wallet Admin convention of using current non-cancelled payments in their creation month.

What was changed

Updated both payment-value queries to include latest non-cancelled payment records and group gross member amounts by payment creation month. Updated the dashboard documentation to describe the corrected projection semantics.

Any added/updated tests

Updated dashboard SQL regression coverage to require creation-month and non-cancelled selection for both payment charts and to reject PAID/date-paid filtering.
@jmgasper
jmgasper merged commit 49cc9c1 into develop Aug 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant