Conversation
What was broken The Reports Portal API returned only the original dashboards, so it could not supply monthly member payment values by type or by customer. Root cause There were no dashboard SQL queries, DTOs, service mappings, or export paths for the two member payment datasets. What was changed Added monthly payment totals by canonical payment type and by the top five clients plus Other Customers, including zero-filled ranges, aggregate and detail responses, CSV exports, Swagger metadata, and API documentation. Any added/updated tests Added and updated dashboard controller, service, and SQL tests for amount mapping, payment categories, customer ranking, zero filling, and CSV output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Reports Portal API returned only the original dashboards, so it could not supply monthly member payment values by type or by customer.
Root cause
There were no dashboard SQL queries, DTOs, service mappings, or export paths for the two member payment datasets.
What was changed
Any added/updated tests
pnpm lintandpnpm buildpass. The full repository suite was also run; 3 unrelated SFDC/report-directory suites fail on unchanged code paths, while 19 suites and 338 tests pass.