Conversation
What was broken The Test Challenge checkbox added by the earlier PM-5802 implementation was not shown in Work Manager's Advanced Options section. Root cause The field was rendered unconditionally in Basic Information, and its tests only queried the page globally instead of checking the required section. What was changed Keep the checkbox in Basic Information before the first save so the test metadata can be sent on initial creation, then render it in Advanced Options for saved challenges. Update the challenge editor documentation to describe the two-stage placement. Any added/updated tests Update ChallengeEditorForm coverage to verify a persisted test flag is checked in Advanced Options and absent from Basic Information on edit. The focused PM-5802 tests, lint, and production build pass; the full suite retains the same pre-existing failures as origin/dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The earlier PM-5802 implementation added test-challenge metadata handling and the Work Manager checkbox, but saved challenges displayed the checkbox in Basic Information instead of the required Advanced Options section. QA therefore could not find the test challenge flag in the section shown in the failure screenshot.
Root cause
TestChallengeFieldwas mounted unconditionally in the Basic Information grid. The existing component tests queried the checkbox globally, so they verified its value but did not catch the incorrect section placement.What was changed
is_test_challengemetadata on creation.is_test_challenge=truechallenges continue to skip payment creation.Any added/updated tests
ChallengeEditorFormregression coverage to verify persisted true metadata renders checked inside Advanced Options and does not render in Basic Information for an existing challenge.yarn test:no-watch --runTestsByPath src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ChallengeEditorForm.spec.tsx --testNamePattern='test challenge' --silent— passed, 3 tests.yarn lint— passed.yarn run build— passed with existing warnings.yarn test:no-watch --silent— 201 suites and 999 tests passed; 18 suites and 32 tests failed. An untouchedorigin/devworktree produced the exact same failures and totals, confirming this change introduced no test regressions.