Skip to content

Prod deploy - Review context, special roles - #2054

Merged
jmgasper merged 47 commits into
masterfrom
dev
Jul 29, 2026
Merged

Prod deploy - Review context, special roles#2054
jmgasper merged 47 commits into
masterfrom
dev

Conversation

vas3a and others added 30 commits July 15, 2026 08:19
Copilot / reviewer special roles to profiles tab
What was broken
Long assignment labels in the Flexi-Talent member detail view extended beyond the card boundary.

Root cause
The detail label inherited no-wrap pill styling and had no maximum width, so its intrinsic width could exceed the detail pane.

What was changed
Constrained the detail label to the card width and allowed normal wrapping, including breaks within long unbroken values.

Any added/updated tests
Added a MembersView stylesheet regression test covering the width and wrapping rules for long assignment labels.
Fix system admin challenge list legacy handling
PM-5637: Keep long assignment labels inside cards
What was broken

Special-role counts and detail typography did not match the approved values, inherited uppercase styling changed the requested wording, and the loading spinner escaped the role details card.

Root cause (if identifiable)

The initial implementation retained default heading transforms and smaller type rules, while the shared full-height spinner had no bounded local container.

What was changed

Updated the summary count, detail headings, back-link, and metric typography, preserved natural wording, and contained the loading state within the achievements card.

Any added/updated tests

Added regression assertions for the approved typography, casing, and bounded loading state. Targeted profile tests, lint, and the production build pass.
PM-5679: Correct special role details presentation
What was broken
Changing an active development challenge from Scheduled to Immediately could save successfully but still show the active-phase shortening warning.

Root cause (if identifiable)
Work compared submitted and persisted absolute phase end timestamps. The phase scheduler can open an immediate phase a few seconds later and shift its dates while preserving its duration, which the UI misclassified as rejected shortening.

What was changed
Compare canonical submitted and persisted phase durations before showing the partial-save warning. Fall back to end-date comparison only when duration data is unavailable and phase starts are unchanged, and document the updated verification behavior.

Any added/updated tests
Added a save-flow regression for a scheduler-shifted immediate phase with unchanged duration and corrected the existing genuine-shortening fixture to use consistent durations.
PM-5656 allow zoom for showcase media assets
@jmgasper
jmgasper requested a review from kkartunov as a code owner July 29, 2026 00:57
@jmgasper
jmgasper merged commit 7b4b059 into master Jul 29, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants