Conversation
What was broken Manual phase changes published one shared email with raw timestamps for all challenge resources, without honoring each resource's phase-notification preference or member timezone. Root cause The manual phase update path built one common template payload and did not load recipient profile locations, so the timestamp and subject could not be personalized. What was changed Filter to opted-in resources and publish one external.action.email event per unique recipient. Resolve profile locations in bounded batches, default unresolved locations to UTC, format times as MMMM DD, YYYY HH:mm z, and add localized_time and phase_change while preserving the legacy template fields. Removed member profile response logging from the lookup used by this flow. Any added/updated tests Added phase service coverage for individual delivery, preference filtering, email deduplication, local and UTC timestamps, country fallback, open and closed payloads, and reopen wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Manual phase changes published one shared email with raw timestamps for all challenge resources, without honoring each resource's phase-notification preference or member timezone.
Root cause
The manual phase update path built one common template payload and did not load recipient profile locations, so the timestamp and subject could not be personalized.
What was changed
external.action.emailevent per unique recipient.MMMM DD, YYYY HH:mm z.localized_timeandphase_changewhile retaining the existing phase template fields.Any added/updated tests
ChallengePhaseServicesuite passes all 51 tests.pnpm lint: passed.pnpm build: passed.pnpm testcommand was also run; it currently reports 143 unrelated existing failures across legacy suites. The changed phase suite is fully green.