Conversation
What was broken Challenge detail and listing responses counted multiple Design concepts from one member as a single submission, so the Community App displayed an incorrect submissions total. Root cause Challenge API recomputed both final and checkpoint counters with the submitting member ID as the distinct identity for every challenge track. What was changed Use the submission ID as the distinct counter identity for Design challenges while preserving member-based counting for all other tracks. Apply the rule to both checkpoint and non-checkpoint submissions. Any added/updated tests Added regression coverage for multiple final and checkpoint Design concepts from one member across challenge detail and listing responses. Preserved the existing Development-track deduplication coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Challenge detail and listing responses counted multiple Design concepts from one member as a single submission. Community App renders those API counters directly, so five concepts could appear as one submission.
Root cause
Challenge API recomputed both
numOfSubmissionsandnumOfCheckpointSubmissionswithmemberIdas the distinct identity for every track. That is correct for replacement attempts on non-Design challenges, but Design uploads can represent separate concepts.What was changed
Any added/updated tests
pnpm test -- --grep 'returns latest-member submission counters|counts every Design submission',pnpm lint, andpnpm buildpass.The full
pnpm testcommand was also run. It reaches and passes the PM-5761 tests, but the currentdevelopbaseline has unrelated failures across legacy validation assertions and test database setup.