Skip to content

PM-5761: Count every design submission concept - #138

Merged
jmgasper merged 1 commit into
developfrom
PM-5761
Jul 31, 2026
Merged

PM-5761: Count every design submission concept#138
jmgasper merged 1 commit into
developfrom
PM-5761

Conversation

@jmgasper

Copy link
Copy Markdown
Contributor

What was broken

Challenge detail and listing responses counted multiple Design concepts from one member as a single submission. Community App renders those API counters directly, so five concepts could appear as one submission.

Root cause

Challenge API recomputed both numOfSubmissions and numOfCheckpointSubmissions with memberId as the distinct identity for every track. That is correct for replacement attempts on non-Design challenges, but Design uploads can represent separate concepts.

What was changed

  • Use submission ID as the distinct counter identity for Design challenges.
  • Preserve member-based counting for all other tracks.
  • Apply the Design rule to both checkpoint and non-checkpoint submissions.

Any added/updated tests

  • Added a regression test with five Design concepts from one member, covering both final and checkpoint counters in challenge detail and listing responses.
  • Preserved and reran the existing Development regression to verify repeated attempts still count once per member.
  • pnpm test -- --grep 'returns latest-member submission counters|counts every Design submission', pnpm lint, and pnpm build pass.

The full pnpm test command was also run. It reaches and passes the PM-5761 tests, but the current develop baseline has unrelated failures across legacy validation assertions and test database setup.

What was broken

Challenge detail and listing responses counted multiple Design concepts from one member as a single submission, so the Community App displayed an incorrect submissions total.

Root cause

Challenge API recomputed both final and checkpoint counters with the submitting member ID as the distinct identity for every challenge track.

What was changed

Use the submission ID as the distinct counter identity for Design challenges while preserving member-based counting for all other tracks. Apply the rule to both checkpoint and non-checkpoint submissions.

Any added/updated tests

Added regression coverage for multiple final and checkpoint Design concepts from one member across challenge detail and listing responses. Preserved the existing Development-track deduplication coverage.
@jmgasper
jmgasper merged commit 0126acc into develop Jul 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant