Skip to content

Drop support for Python 3.10 - #276

Merged
goncalossilva merged 1 commit into
mainfrom
goncalossilva/drop-python-3.10
Nov 16, 2026
Merged

goncalossilva merged 1 commit into
mainfrom
goncalossilva/drop-python-3.10

Conversation

@goncalossilva

Copy link
Copy Markdown
Member

Drop Python 3.10 support after its end of life on October 1, 2026. Require >=3.11,<4, align CI/tox/Ruff and documentation, and remove the obsolete UTC/Self compatibility fallbacks.

Regenerate uv.lock without upgrading dependencies: remove Python 3.10-only resolutions, including vulnerable filelock 4.1.0, while retaining filelock 4.2.4. Related #272 currently upgrades 4.2.4 → 4.2.10 only on Python 3.11+ despite its stale title/body; this PR removes the unsupported path that it leaves behind and does not incorporate that upgrade.

Verified: 91 tests pass on each of Python 3.11–3.14; wheel/sdist metadata, installed-wheel smoke tests, docs build, source mypy, and lock checks pass. Full-repository Ruff/mypy and pre-commit failures reproduce on main with no new findings.

@goncalossilva
goncalossilva requested a review from a team as a code owner November 16, 2026 18:17
@goncalossilva
goncalossilva requested review from PotHix and a balanced review from Copilot and removed request for a team November 16, 2026 18:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change raising the minimum supported Python version to 3.11.

No open issues 🎉

What changed in this PR

Drops Python 3.10 support from the Todoist Python SDK and aligns packaging, tooling, tests, and documentation with Python >=3.11,<4.

Changes:

  • Raises the minimum Python version and removes Python 3.10 from CI and tox.
  • Replaces UTC and Self compatibility fallbacks with standard-library imports.
  • Removes Python 3.10-only lockfile resolutions, including filelock 4.1.0, while retaining filelock 4.2.4 without dependency upgrades.
File Description
uv.lock Updates Python constraints and removes obsolete resolutions and wheels.
tox.ini Removes the Python 3.10 test environment.
todoist_api_python/​api.py Imports Self directly from typing.
todoist_api_python/​api_async.py Imports Self directly from typing.
todoist_api_python/​_core/​utils.py Imports UTC directly from datetime.
tests/​test_api_tasks.py Removes the UTC compatibility fallback.
tests/​test_api_completed_tasks.py Removes the UTC compatibility fallback.
README.md Documents the supported Python range.
pyproject.toml Raises the Python minimum and Ruff target to 3.11.
CHANGELOG.md Records Python 3.10 removal as a breaking change.
.github/​workflows/​test.yml Removes Python 3.10 from the CI matrix.

Review effort: Balanced

@PotHix PotHix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it! It will require a major version, though.

from datetime import UTC, datetime
from typing import TYPE_CHECKING, Any

if sys.version_info >= (3, 11):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing workarounds 😌

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This was mostly done now for security reasons, but this is nice. 😁

@doistbot doistbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates Drop support for Python 3.10. No issues were flagged in the reviewed diff.

Share Feedback • Review Logs • Trace

@goncalossilva
goncalossilva merged commit acc29fc into main Nov 16, 2026
6 checks passed
@goncalossilva
goncalossilva deleted the goncalossilva/drop-python-3.10 branch November 16, 2026 18:25
@goncalossilva

Copy link
Copy Markdown
Member Author

It will require a major version, though.

Will it? I assume consumers on 3.10 would simply not get the new version (so it's not breaking).

@PotHix

PotHix commented Nov 17, 2026

Copy link
Copy Markdown
Member

Will it? I assume consumers on 3.10 would simply not get the new version (so it's not breaking).

That's an interesting point! It's a breaking change, but there are enough limits to not break it without people knowing it :)
It should be OK as a minor, then. We just need to be explicit in the release that we are dropping 3.10 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants