fix(clickhouse): parse MODIFY COLUMN as AlterColumn - #8091
Open
dgvj-work wants to merge 2 commits into
Open
Conversation
ClickHouse treats MODIFY COLUMN and ALTER COLUMN as equivalent, so map MODIFY through the alter-column parser and return AlterColumn. Generation canonicalizes to ALTER COLUMN ... TYPE. IF EXISTS is parsed on AlterColumn and emitted when the dialect supports it. Fixes tobymao#8019
Handle unsupported ALTER COLUMN IF EXISTS with an explicit check instead of decorating altercolumn_sql overrides, which failed sqlglotc builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickHouse treats
MODIFY COLUMNandALTER COLUMNas equivalent.MODIFY COLUMNwas falling back toCommandbecause the ClickHouseMODIFYalter parser only handledMODIFY SQL SECURITY ....This maps
MODIFYthrough the alter-column parser (same idea as Snowflake), returnsAlterColumn, and canonicalizes generation toALTER COLUMN ... TYPE.IF EXISTSis parsed onAlterColumnand emitted for ClickHouse. Forms the base parser cannot consume (for exampleREMOVE) still fall back toCommand.Follow-up to #8020 addressing @treysp's review feedback.
Fixes #8019