Skip to content

Cast REAL to numeric before ROUND in Postgres [CLAUDE] #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chuenchen309 wants to merge 1 commit into from
+6 −1
Closed

Cast REAL to numeric before ROUND in Postgres [CLAUDE] #7906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlglot/generators/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def _round_sql(self: PostgresGenerator, expression: exp.Round) -> str:

# ROUND(double precision, integer) is not permitted in Postgres
# so it's necessary to cast to decimal before rounding.
if expression.this.is_type(exp.DType.DOUBLE):
if expression.this.is_type(*exp.DataType.FLOAT_TYPES):
decimal_type = exp.DType.DECIMAL.into_expr(expressions=expression.expressions)
this = self.sql(exp.Cast(this=this, to=decimal_type))

Expand Down
5 changes: 5 additions & 0 deletions tests/dialects/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,6 +1798,11 @@ def test_round(self):
"bigquery": "ROUND(x::DOUBLE, 4)",
},
)
# ROUND(real, integer) is not permitted in Postgres either, so REAL must be cast too.
self.validate_all(
"ROUND(CAST(CAST(x AS REAL) AS DECIMAL), 4)",
read={"postgres": "ROUND(x::REAL, 4)"},
)
Comment on lines +1802 to +1805

@geooo109 geooo109 Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't supported in postgres, there is no need to cover garbage input and fix it in the output.

ref: #7905 (comment)

self.validate_all(
"ROUND(CAST(x AS DECIMAL(18, 3)), 4)", read={"duckdb": "ROUND(x::DECIMAL, 4)"}
)
Expand Down
Loading