fix: render FOR VERSION/TIMESTAMP FROM/BETWEEN bounds, not a tuple [CLAUDE]#7903
Closed
chuenchen309 wants to merge 1 commit into
Closed
fix: render FOR VERSION/TIMESTAMP FROM/BETWEEN bounds, not a tuple [CLAUDE]#7903chuenchen309 wants to merge 1 commit into
chuenchen309 wants to merge 1 commit into
Conversation
…LAUDE]
version_sql emitted the two range bounds as the underlying Tuple, so
`FOR VERSION BETWEEN '1' AND '2'` round-tripped to
`FOR VERSION BETWEEN ('1', '2')` (and FROM ... TO likewise). Render the
bounds joined by AND/TO instead.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base
version_sqlrenders aFROM/BETWEENtime-travel range straight from itsTuple, so a valid range comes back as a tuple literal:FROM '1' TO '2'is affected the same way. The parser stores the two bounds as aTuple, but for these two kinds they need to be joined byAND/TOrather than emitted as(start, end).CONTAINED IN (...),AS OFandALLare unchanged.Added two identity cases to the Presto tests; both fail on
mainand pass here. Full suite green.Disclosure: found and fixed with Claude Code — the AI hit the round-trip mismatch, wrote the fix and the tests. I review every change and am responsible for it; the fail-before/pass-after tests re-run from the diff.