Repository navigation
fix(tests): fix flaky test_capture_pane_flags[join_wrapped_numbers] - #655
Merged
Merged
Conversation
tony
marked this pull request as ready for review
April 1, 2026 23:58
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #655 +/- ##
=======================================
Coverage 52.45% 52.45%
=======================================
Files 26 26
Lines 3729 3729
Branches 747 747
=======================================
Hits 1956 1956
Misses 1469 1469
Partials 304 304 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
April 26, 2026 10:22
0cecae7 to
7bb49f0
Compare
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
May 10, 2026 16:02
7bb49f0 to
33e94ab
Compare
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
May 30, 2026 11:54
33e94ab to
cb5ebd4
Compare
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
July 4, 2026 13:40
cb5ebd4 to
6c451e1
Compare
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
July 18, 2026 11:02
6c451e1 to
a468e8e
Compare
tony
added a commit
that referenced
this pull request
Oct 2, 2026
why: Four tests read a pane before the state they assert had arrived, or waited on text the shell echoes back as it is typed. Under 40 busy loops: `test_capture_pane`, `_start` and `_end` failed 10 of 192 runs (each asserts the pane's exact text straight after `new_window` or `send_keys`), and `test_capture_pane_flags[join_wrapped_numbers]` failed 3 of 96, because the echoed command line already contains the "done" marker. #655 skips echo lines that start with "$", which holds only while the echoed command fits on one line: with a 40-column pane the wrapped continuation line, which has no "$", still matches. The `automation_patterns` doctest has the same flaw, plus a single-shot read after the marker: it failed on every run on a machine with a slow login shell. what: - Poll each exact-text assertion in the three `capture_pane` tests until the pane holds the expected text, then assert it - Type the `capture_pane_flags` marker as `"__DONE_""id__"` so only the command's output contains it - Rewrite the "Capturing output between markers" example to wait for an end marker printed last, with split markers, and say why Verified under the same load: 0 of 192 for each test file, and 0 of 24 for the doctest (24 of 24 before).
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
November 7, 2026 02:18
a468e8e to
3dd988f
Compare
tony
changed the title
test_capture_pane_flags[join_wrapped_numbers]
why: The command_complete() check matched the marker string inside the shell command echo line ($ printf ... echo "__DONE_...") before the command actually executed. On slower systems or CI, this race condition caused the test to capture the pane before seq produced output. what: - Change marker detection to skip lines starting with $ (shell prompt echo) - Marker now only matches when it appears as actual command output Fixes #654
tony
force-pushed
the
fix/flaky-join-wrapped-numbers-test
branch
from
November 8, 2026 00:21
3dd988f to
2a4819d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_capture_pane_flags[join_wrapped_numbers]where the completion marker was detected in the shell command echo before the command actually executedTest plan
uv run py.test tests/test_pane_capture_pane.py -v— all 19 tests passFixes #654