Repository navigation
Require Sailfish quorums to be upward closed - #241
Open
Qian-Cheng-nju wants to merge 1 commit into
Open
Qian-Cheng-nju wants to merge 1 commit into
Qian-Cheng-nju wants to merge 1 commit into
Conversation
Signed-off-by: Qian-Cheng-nju <Qian-Cheng-nju@users.noreply.github.com>
Qian-Cheng-nju
force-pushed
the
sailfish-quorum-closure
branch
from
October 20, 2026 17:24
478fc38 to
9a56943
Compare
Member
|
/cc ^^ @nano-o |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is one more quorum assumption missing after #233: a superset of a quorum must still be a quorum.
For example, the existing assumptions allow:
Here
{a,b,c}is a quorum, but{a,b,c,d}is not. In an 11-transition replay, the three correct nodes vote for the round-1 leader, thendadds a vote. The resulting vote set failsIsQuorum, so a correct node enters round 3 without committing the round-1 leader, violatingLiveness.This states upward closure in
Sailfishand checks it in both TLC wrappers. Ordinary threshold quorums satisfy it.The new assumption rejects the counterexample parameters before initialization. Taking the upward closure of the same quorum family lets the replay complete and commit the leader. The existing
TLCSailfish1model also passes with unchanged state counts.