Repository navigation
Avoid splitting a nonexistent B-tree root parent - #239
Open
Qian-Cheng-nju wants to merge 1 commit into
Open
Qian-Cheng-nju wants to merge 1 commit into
Qian-Cheng-nju wants to merge 1 commit into
Conversation
Signed-off-by: Qian-Cheng-nju <Qian-Cheng-nju@users.noreply.github.com>
Qian-Cheng-nju
force-pushed
the
btree-root-split
branch
from
October 20, 2026 17:24
ea122dc to
3264cab
Compare
Member
|
/cc ^^ @lorin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WhichToSplitcomputesAtMaxOccupancy(ParentOf(node))even whennodeis the root. The root has no parent, so this value is unspecified. If it is true, both of theseCASEguards hold:TLA+ does not give the first matching arm priority. Taking the second arm can push a value outside
NodesontotoSplit, violatingTypeOk. TLC normally takes the first arm and hides the overlap.Set
splitParenttoFALSEat the root. Non-root splitting keeps the same condition.I checked a 10-state witness after inserting keys 1 and 2 and starting an insertion of 3. Giving the empty parent choice the value
NIL, givingkeysOf[NIL]a full occupancy, and selecting the parent arm reproduces the violation. These are explicit interpretations of unspecified values, not a counterexample from TLC's default evaluation. With the fix, the same witness keeps the root on the stack and entersSPLIT_ROOT_LEAF. The existingMCbtree.cfgpasses with unchanged state counts.