Repository navigation
runtime: fully implement GOROOT and GODEBUG #5885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jakebailey
wants to merge
4
commits into
tinygo-org:dev
Choose a base branch
from
jakebailey:runtime-godebug-environment
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+582
−26
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2e0adb2
runtime: use GOROOT from the startup environment
jakebailey 024c544
runtime: initialize GODEBUG settings
jakebailey 539910f
runtime: notify GODEBUG when the environment is removed
jakebailey 0f1fcdd
runtime: prune unused startup environment handling
jakebailey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package compiler | ||
|
|
||
| import ( | ||
| "golang.org/x/tools/go/ssa" | ||
| "tinygo.org/x/go-llvm" | ||
| ) | ||
|
|
||
| func (b *builder) markRuntimeFeatureUse(call *ssa.CallCommon) { | ||
| callee := call.StaticCallee() | ||
| if callee == nil { | ||
| return | ||
| } | ||
|
|
||
| var markerName string | ||
| switch b.getFunctionInfo(callee).linkName { | ||
| case "runtime.GOROOT": | ||
| markerName = "tinygo.runtime.feature.goroot" | ||
| case "(*internal/godebug.Setting).Value": | ||
| markerName = "tinygo.runtime.feature.godebug" | ||
| case "internal/godebug.setUpdate": | ||
| if b.fn.Pkg != nil && b.fn.Pkg.Pkg.Path() == "internal/godebug" { | ||
| return | ||
| } | ||
| markerName = "tinygo.runtime.feature.godebug" | ||
| default: | ||
| return | ||
| } | ||
|
|
||
| marker := b.mod.NamedFunction(markerName) | ||
| if marker.IsNil() { | ||
| marker = llvm.AddFunction(b.mod, markerName, llvm.FunctionType(b.ctx.VoidType(), nil, false)) | ||
| } | ||
| b.CreateCall(marker.GlobalValueType(), marker, nil, "") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| //go:build darwin || windows || wasip1 || (linux && !baremetal && !wasm_unknown && !wasip2 && !nintendoswitch) | ||
|
|
||
| package runtime | ||
|
|
||
| import "unsafe" | ||
|
|
||
| //export getenv | ||
| func libc_getenv(name *byte) *byte | ||
|
|
||
| func startupEnv(key string) string { | ||
| name := make([]byte, len(key)+1) | ||
| copy(name, key) | ||
| value := libc_getenv(&name[0]) | ||
| if value == nil { | ||
| return "" | ||
| } | ||
| length := strlen(unsafe.Pointer(value)) | ||
| return string(unsafe.Slice(value, length)) | ||
| } | ||
|
|
||
| func init() { | ||
| if gorootEnvEnabled() { | ||
| if value := startupEnv("GOROOT"); value != "" { | ||
| goroot = value | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| //go:build (linux && !baremetal && !wasm_unknown && !wasip2 && !nintendoswitch) || darwin || windows | ||
|
|
||
| package runtime | ||
|
|
||
| func init() { | ||
| if godebugEnvEnabled() { | ||
| godebugStartup = startupEnv("GODEBUG") | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This puts the feature-gate calls in the same initializer that parses
osArgsandosEnv. Interp runs before the optimizer resolves these gates, so it cannot interpret this initializer and leaves the parsing code to run at startup. Could we split the gate checks into a second initializer?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed that, but not really clear it did much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I’ll test.