Repository navigation
fix(dev-admin): gate the AI proxy and service probes like /__dev - #237
Merged
Merged
Conversation
The dev-admin routes that live outside /__dev (/ai/api/chat and the /ai, /vision, /embed, /image, /rag probes) skipped the Host, same-origin and loopback-peer checks every /__dev route takes. They now pass through the same gate. The dashboard's own same-origin calls are unaffected. Signed-off-by: Michael <michael@codeinfinity.co.za>
Collaborator
Author
|
I have read the Tina4 Contributor Licence Agreement and I agree to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev-admin routes that sit outside
/__dev— the AI gateway proxy and the service probes the dashboard calls — were not covered by the dev-admin gate (Host allow-list, same-origin, loopback peer) that every/__devroute takes. They now go through the same gate, so they behave exactly like the rest of the dev admin. The dashboard's own same-origin calls keep working.Tests: a new suite drives the real front controller and asserts refused callers never reach the gateway, plus a positive control for the dashboard. It fails on the current tip and passes with this change. Full suite shows no new failures.