tests: cover native VM module fallback regressions#255
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
qagame -> game -> server,cgame -> client,ui -> frontend, and reverse aliases).vmMainargument packing for direct native VM calls, including zero-filled missing argument slots so zero/one-argument calls do not read stack garbage.Test files added/updated
tests/unit/test_vm_native_module.cCMakeLists.txttests/README.mdWhy this materially reduces regression risk
vm.cwithout direct unit coverage.Validation
cmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=ONcmake --build build-coverage-tests --target unit_vm_native_modulectest --test-dir build-coverage-tests -R unit_vm_native_module --output-on-failurecmake --build build-coverage-tests --target idtech3_server