Skip to content

tests: cover renderer regression map runner#248

Draft
cursor[bot] wants to merge 1 commit into
next-gen-5from
cursor/missing-test-coverage-d0bd
Draft

tests: cover renderer regression map runner#248
cursor[bot] wants to merge 1 commit into
next-gen-5from
cursor/missing-test-coverage-d0bd

Conversation

@cursor

@cursor cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

Summary

  • Adds deterministic script coverage for scripts/renderer_regression_maps.sh using an isolated fixture and stub idtech3_server.
  • Registers the new test_renderer_regression_maps CTest target and documents it in tests/README.md.

Risky behavior now covered

  • GAME_BASE is translated into the expected fs_basepath parent and fs_game basename for all six renderer regression maps.
  • Dedicated-server map-load args remain stable (dedicated, vm_game, bot_enable, com_hunkMegs, +map).
  • Server-log error patterns and missing/invalid GAME_BASE fail the gate instead of silently passing.

Why this reduces regression risk

The map runner is the Tier B content-backed renderer validation entry point. Regressions in path derivation, map iteration, or failure detection could produce false confidence in renderer validation; this test catches those without requiring real game data or a GPU.

Validation

  • tests/scripts/test_renderer_regression_maps.sh scripts/renderer_regression_maps.sh
  • cmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF
  • ctest --test-dir build-coverage-tests -R test_renderer_regression_maps --output-on-failure
Open in Web View Automation 

Co-authored-by: Tim Fox <timfox@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant