Add Vulkan Forward+ PBR regression guards#239
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/README.md.Risky behavior now covered
ADD_FRAG_SPECentries must remain contiguous, within both PBR/non-PBRspec_entries[]capacities, and aligned with GLSLconstant_iddeclarations.forward_plus_shade_strengthstays mapped to constant id 40 and clamped before pipeline specialization.r_forwardPlusLuminanceSortremains default-on, range-checked, runtime-toggleable, pushed into the compute shader, and honored by shader-side brightest-light selection.Test files added/updated
tests/scripts/test_vulkan_forward_plus_pbr_guards.py.CMakeLists.txtto registertest_vulkan_forward_plus_pbr_guardswhen Python3 is available.tests/README.mdtest inventory.Why this reduces regression risk
These paths are high-blast-radius renderer logic that is difficult to exercise on headless CI with real Vulkan hardware. The new guard catches source-level regressions that could otherwise reintroduce specialization-map overflows, shader/C constant-id drift, or broken Forward+ luminance sorting.
Validation
python3 tests/scripts/test_vulkan_forward_plus_pbr_guards.py /workspacecmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF && ctest --test-dir build-coverage-tests -R test_vulkan_forward_plus_pbr_guards --output-on-failurectest --test-dir build-coverage-tests -R 'test_vulkan_(runtime_regressions|renderer_guards|regression_source_guards|forward_plus_pbr_guards)' --output-on-failure