test: guard client demo record/playback invariants#237
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_client_demo_regressionsto guard the recentcl_demo.cextraction and client demo record/playback behavior.tests/README.md.Risky behavior now covered
Test files added/updated
tests/scripts/test_client_demo_regressions.shCMakeLists.txttests/README.mdWhy this reduces regression risk
The recent demo-module extraction moved a core client flow with file parsing and protocol edge cases. This deterministic source-level test prevents future edits from weakening bounds checks, fallback behavior, or lifecycle wiring without requiring display, GPU, or game data.
Validation
./tests/scripts/test_client_demo_regressions.sh /workspacecmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFFctest --test-dir build-coverage-tests -R test_client_demo_regressions --output-on-failure