Add support for reference time per observation well - #168
Open
dbrakenhoff wants to merge 6 commits into
Open
Conversation
dbrakenhoff
commented
Jul 8, 2026
dbrakenhoff
commented
Contributor
- allow adding reference time per calibration time series
- use local reftime first, then global setting
- update plot_transient_results to cycle colors by default. override for constant color.
- add support for reftime in plot_transient results.
- allow adding reference time per calibration time series - use local reftime first, then global setting - update plot_transient_results to cycle colors by default. override for constant color. - add support for reftime in plot_transient results.
- add names for all observations dataclasses (nice for logging/errors) - only log error about normalization when reference time is set to None, otherwise time series is automatically normalized. - do not include reference time observation in residual calculation
- neglect steady when obs is normalized
- add option to compute weighted or unweighted statistics - add nse statistic
- fix residuals coming out as none when reference time is set caused by incorrect indexing in mask which was unexpectedly 2d - remove plot xlims being set to view all data - make reference time line a little thicker for nicer visualization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.